Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds round end to status tab #4460

Closed
wants to merge 5 commits into from

Conversation

BeagleGaming1
Copy link
Contributor

@BeagleGaming1 BeagleGaming1 commented Sep 21, 2023

About the pull request

Lets ghosts and new players (lobby) see time to server restart

Explain why it's good for the game

Lets you see if the automatic round-end timer ran out, and if the server is delayed

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
add: Ghosts and players in lobby can see the time to the server restarting in the status tab
/:cl:

@github-actions github-actions bot added the Feature Feature coder badge label Sep 21, 2023
code/modules/mob/new_player/new_player.dm Outdated Show resolved Hide resolved
code/modules/mob/dead/observer/observer.dm Outdated Show resolved Hide resolved
@realforest2001 realforest2001 marked this pull request as draft September 22, 2023 01:26
@BeagleGaming1 BeagleGaming1 marked this pull request as ready for review September 22, 2023 02:07
@BeagleGaming1
Copy link
Contributor Author

Bruh its like 10s off on live

Copy link
Member

@morrowwolf morrowwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allegedly weirdness with the timer during TM

@morrowwolf morrowwolf marked this pull request as draft September 26, 2023 10:36
@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Oct 2, 2023
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@morrowwolf morrowwolf closed this Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Merge Conflict PR can't be merged because it touched too much code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants